Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <h5> with <h2> and wrap <p class="foot"> in the footer tag to fix the accessibility issue.
Add the alt attribute
alt=" "
to the img tag and give it a value to fix the error issue. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.To center the main on the page using flexbox, replace the height in the body with min-height: 100vh.
Give the body a background-image with a background-size of contain and a background repeat of no repeat.
For a responsive content , replace the width in the main with max-width and increase it value for it to be equivalent to the design. `max-width:432px which is 27rem/em'
this challenge requires a media query , in the media query you only have to change the background-image of the body.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1 - @frank-itachiPosted over 1 year ago
Hello there π. You did a good job!
I have some suggestions about your code that might interest you.
HTML π:
- The heading order is important in the html structure so try to always start your headings and/or titles with an
<h1>
tag and then you can increase by one if you need to use more headings in your html code. - Make sure that the
<img>
elements in your HTML code has an alternate (descriptive) short text. The reason for this is that screen readers canβt translate images into text. So to fix this you can do the following<img src=ββ¦β alt=βshort textβ >
I hope you find it useful! ππ Above all, the solution you submitted is greatπ!
Happy
<coding />
π!1 - The heading order is important in the html structure so try to always start your headings and/or titles with an
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord