Travolgi 🍕• 31,420
@denielden
Posted
Hello Mario, You have done a good work! 😁
Some little tips to improve your code:
- To fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center;
background-size: contain;
background-color: #e0e8ff;
- add
maintag and wrap the card for improve the Accessibility - also you can use
articletag instead of a simpledivto the container card for improve the Accessibility - add descriptive text in the
altattribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
divcontainer of image
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
1
marioferrer• 140
@marioferrer
Posted
Hi @denielden, thank you very much.
- I have already fixed the background image, also I have completed it using the shorthand for all the properties.
- I have also changed the div that wraps the card to a main tag.
- I have added a descriptive text to the banner image with the alt attribute.
- I have removed the div that wrapped the banner image because you were right and it didn't do any function.
1
Travolgi 🍕• 31,420
@denielden
Posted
@marioferrer you are welcome and keep it up :)
1
