Skip to content
Submitted over 1 year ago

Order summary solution

Nohelynaid•180
@Nohelynaid
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

It is actually working pretty well but somehow the background image cannot be displayed or its not compatible. FEEDBACK!

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    BG iMAGE WITH CSS 📸:

    • let me explain, How you can easily apply the background color with the svg they provided.
    • Add the following style rule to your css, and then experience the changes
    body {
    background: url(/pattern-background-desktop.svg), #E1E9Ff;
    background-repeat: no-repeat, no-repeat;
}
    • Tip, Don't forget to generate a new screenshot after editing the css file

    ESSENTIALS ♻️:

    • This solution has generated accessibility error reports due to lack of title tag inside html element
    • The <title> tag defines the title of the document. The title must be text-only, and it is shown in the browser's title bar or in the page's tab.
    • The <title> tag is required in HTML documents, The contents of a page title is very important for search engine optimization (SEO). <html> element must have a title tag, so fix it by adding,
    • <title>Order summary component</title> inside the html

    HTML 🏷️:

    • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage
    • So fix it by replacing the <div class="container-fluid"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
    • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

    HEADINGS ⚠️:

    • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>
    • Every site must want at least one h1 element identifying and describing the main content of the page.
    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
    • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
  • Danilo de Oliveira•70
    @DariluPosted over 1 year ago

    hello, I tried to fix the problem in the background. and following this path, I was able to include the background image.

    body {
   margin: auto;
   font-family: 'Red Hat Display', sans-serif;
   text-align: center;
   background-image: url("../images/bg-desktop.svg");
   background-repeat: no-repeat;
   background-size: contain;
}

    the repeat and size properties were just to get it right, but feel free to change it.

    Hope this helps.

    Marked as helpful
    0
    Nohelynaid•180
    @NohelynaidPosted over 1 year ago

    @Darilu THANK YOU! It really has been helpful! and I have tried it ever since I read your comment.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord