Design comparison
SolutionDesign
Solution retrospective
I had fun during this challenge and I will be grateful to receive any ctiqs from anyone on what I could improve on.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello, John! 👋
Congratulations on finishing this challenge! 🎉 It's great to hear that you had fun while building it. Hopefully, you also learned a lot while building it. 😄
There are two things that you can do to improve this solution.
- Firstly, I would strongly recommend making your solution looks more similar to the design. Right now, if you see the design comparison, the card looks much bigger than the original design.
- Secondly, I suggest using flexbox to make the card in the middle of the page and removing the
min-height
property from thecontainer
element instead put it on thebody
element. The card should not always have full height but thebody
element needs to always fill the entire page.
Hope you find this useful and happy coding! 😁
Marked as helpful2 - @hopzinga22Posted over 2 years ago
Thanks. I will improve on your points on my next challenge. Thanks for the feedback.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord