Design comparison
Community feedback
- @Sdann26Posted over 2 years ago
Hi mohammed!
You have done well, although I would have recommended you to give the background directly to the body with the size contain value, but even so you have done quite well.
By the way you have accessibility errors that we can easily correct:
To do this place the <main> tag inside the body and that encompasses all the content of this. It is because the main tag should always have the main content of the page, for the rest there is nav, footer, aside, etc..
In addition when you use the elements h1, h2... etc. Only use them as titles and in an incremental way since the h1 would be the title of all the h2 and the h2 contains the h3 subtitles and so on. It makes no sense to have put h4 to "Annual Plan" if you want to skip the error better change it to h2.
Apart from that everything else is perfect. The effects, the responsive, the design.
Well done, successes, good coding!
Marked as helpful0@moakintundePosted over 2 years ago@Sdann26 thanks for your feedback.
I've gone back and made modifications and was able to correct the accessibility issues ⚠️ . I've previously had same issue from my last challenge submitted but with your break down it was clear enough this time. Thanks.
0@moakintundePosted over 2 years ago@Sdann26 Also about making the background image as such I was trying out new patterns to how I can layout. This was why I did it this way.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord