Travolgi 🍕• 31,400
@denielden
Posted
Hi Vijay, good job! I took some time to look at your code and have some ideas for improving it:
- add
main
tag and wrap the card for improve the Accessibility - add descriptive text in the
alt
attribute of the image - use
button
tag insteada
for the payment button - centering a
div
withabsolute
positioning is now deprecated, it uses modern css likeflexbox or grid
and in you case is superfluous because you use flex to the body - remove all
margin
fromcard
class because with flex they are superfluous - add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container
Overall you did well 😉
Hope this help and happy coding!
Marked as helpful
1
vijay0609• 90
@vijay0609
Posted
@denielden thank you very much danielden for sharing this , I have already started working on my next projects with the thing you said thank you for your comment
1
vijay0609• 90
@vijay0609
Posted
@denielden thank you very much danielden for sharing this , I have already started working on my next projects with the thing you said thank you for your comment
1