Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

order summary

vijay0609 90

@vijay0609

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,400

@denielden

Posted

Hi Vijay, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • use button tag instead a for the payment button
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid and in you case is superfluous because you use flex to the body
  • remove all margin from card class because with flex they are superfluous
  • add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

Overall you did well 😉

Hope this help and happy coding!

Marked as helpful

1

vijay0609 90

@vijay0609

Posted

@denielden thank you very much danielden for sharing this , I have already started working on my next projects with the thing you said thank you for your comment

1
vijay0609 90

@vijay0609

Posted

@denielden thank you very much danielden for sharing this , I have already started working on my next projects with the thing you said thank you for your comment

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord