Order summary page with html and CSS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Greetings, Stephanie! 👋

  Great work on this challenge! Your solution looks pretty good! 😀

  Here are some areas that you can improve.

  • Not all images need alternative text. In this case, all the images are decorative images which mean that even if the images doesn't exist, the users still be able to understand and interact with the site. So, you could leave the alt="" empty and to prevent VoiceOver screen reader pronounce the empty alt images, add aria-hidden="true".
  • Always specify the type of the button. In this case, set the type of them as type="button". It's going to prevent the button from behaving unexpectedly (like submitting).
  • I would recommend adding some padding on the body element to prevent the card from having a full width on mobile view, my mobile screen size is 360px * 640px.

  I hope this helps! Keep up the good work! 👍

  Marked as helpful

  0

  ---

  

  Stephanie Ezinne•140

  @stephanniegbPosted over 2 years ago

  @vanzasetia thank you

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @stephanniegb You're welcome! 😉

  0
• 

  2div•170

  @2divPosted over 2 years ago

  Hello Stephanie First of all congratulation on completing this challenge and your solution is very good. below are my tips for improvement :

  • Fix the a accessibility issue by change h2 to h1
  • Also you need to increase the border radius for the box and the button
  • You need to check the size for mobile screen because card look large.

  over all you did great.

  Marked as helpful

  0