@vanzasetia
Posted
Greetings, Stephanie! 👋
Great work on this challenge! Your solution looks pretty good! 😀
Here are some areas that you can improve.
- Not all images need alternative text. In this case, all the images are decorative images which mean that even if the images doesn't exist, the users still be able to understand and interact with the site. So, you could leave the
alt=""
empty and to prevent VoiceOver screen reader pronounce the emptyalt
images, addaria-hidden="true"
. - Always specify the
type
of thebutton
. In this case, set the type of them astype="button"
. It's going to prevent the button from behaving unexpectedly (like submitting). - I would recommend adding some
padding
on thebody
element to prevent the card from having a full width on mobile view, my mobile screen size is 360px * 640px.
I hope this helps! Keep up the good work! 👍
Marked as helpful
@stephanniegb
Posted
@vanzasetia thank you
@vanzasetia
Posted
@stephanniegb You're welcome! 😉