Design comparison
Solution retrospective
Is there any problems with code or accessibility or best practices I can use to make my solution better? I appreciate all feedback.
Community feedback
- @denieldenPosted almost 3 years ago
Hi Omar, great work!!
For center the card add the
height
properties to thebody
. Flexbox aligns to the size of the parent containerYou can use the
vh
measurement for the height... Viewport Height handles the sizing of an element in relation to the height of the browser window.I hope that helps ;)
Marked as helpful1 - @rsrclabPosted almost 3 years ago
Hi, @hazel79 ~
Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.
Here are some of the tips I like to provide.
- On smaller devices, card goes over screen, and I think removing
min-width
on smaller devices can solve this issue. - I suggest you to try transition on hoverable elements like image, heading and creator name.
- Please try BEM for naming element classes. It will help you a lot on bigger projects.
If it can help you even a bit, it would be happy to me.
Cheers ~
Marked as helpful1 - On smaller devices, card goes over screen, and I think removing
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord