Design comparison
SolutionDesign
Community feedback
- @denieldenPosted almost 3 years ago
Hi Khairan, good job! Congratulations on completing the challenge.
I have some advice for you:
- add
main
tag and wrap the card for Accessibility - try to remove all
margin
fromentire
class - use flexbox to the body for center the card. Read here -> flex guide
- also set
heigth
of body to100vh
because Flexbox aligns to the size of the parent container.
In the end for fix the top image in the background just put more specific background properties:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
Hope this help ;) and happy coding!
Marked as helpful1@KhairanADijiPosted almost 3 years ago@denielden Hi Deniel! This was incredibly helpful. You addressed issues that actually had me stumped for a while. I really appreciate you taking time out to help. Thank you so much!😊
1@denieldenPosted almost 3 years ago@KhairanADiji You are welcome, I'm glad they helped you! Keep it up :)
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord