Design comparison
Solution retrospective
In this project, I am trying to improve the use of semantic tags in html instead of using divs. I also getting used to BEM naming system.
Community feedback
- @correlucasPosted about 2 years ago
πΎHello Noel, congratulations for your new solution!
Here's some tips for you to improve the responsiveness:
To make your solution even better and more responsive, you can create a media query to break the elements in the
pricing section
and make every content in a different row saving space for low resolution devices.@media (max-width: 350px) { .card__product { display: flex; flex-direction: column; } }
βοΈ I hope this helps you and happy coding!
Marked as helpful0@jayrnoelPosted about 2 years ago@correlucas thank you for the feedback! I was thinking how to do it without branching off from the design and I was only thinking on the constraints of the design provided.
0 - @AdrianoEscarabotePosted about 2 years ago
Hi @jayrnoel, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
The layout result was very similar to the example, but I noticed that the background is not quite the same, you can fix it like this:
body { background: url("./images/pattern-background-desktop.svg") hsl(225,100%,94%); background-repeat: no-repeat; background-size: 100% 50vmin; }
The rest is really good!
Hope it helps... π
Marked as helpful0@jayrnoelPosted about 2 years agoHi @AdrianoEscarabote I have tried your solution and now it's the same. To be honest I did not notice that it was different, for some reason I thought when I applied the background I thought that was it so I just focused on the card itself.
Thank you so much for the feedback and Have a great day!
1@AdrianoEscarabotePosted about 2 years ago@jayrnoel ahahahhaha it's not so easy to see this background color.
no problem bro, keep coding
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord