Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Pablo, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - add descriptive text in the
alt
attribute of the image - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - remove
margin
fromcard
class because with grid they are superfluous - add grid property
place-content: center
to the body for center the card horizontally - instead of using
px
try to use relative units of measurement -> read here - For fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
Overall you did well 😉
Hope this help and happy coding!
Marked as helpful1@BarriosPabloOkPosted over 2 years ago@denielden Thank you very much for giving me these tips. I'm having trouble figuring out the height and width of the card. I'm going to get to work!!!
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord