Order Summary HTML CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BACKGROUND iMAGE 📸:

  • Looks like the background svg and color has not been set, So let me explain How you can easily apply the background color with the svg they provided.

  ---

  • Add the following style rule to your css, and then experience the changes

  body {
      background: url(./images/pattern-background-desktop.svg), #E1E9Ff;
      background-repeat: no-repeat, no-repeat;
  }
  

  ---

  • Tip, Don't forget to generate a new screenshot after editing the css file

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for body element instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Francesco Merighi•930

  @francescomerighi1202Posted over 1 year ago

  @0xAbdulKhalid thanks for the advices!

  0