Order Summary - HTML and CSS

Community feedback

• 

  Brendan•1,120

  @OneManBannedPosted about 1 year ago

  Hi Igor, very nice looking solution. A few bits of advice.

  HTML

  • Very little to say here other than I think the change link would make more sense as a <button>. The <a> element is used to link to other webpages while the <button> element is used to trigger a JavaScript action. Here, I assume in fully working app pressing "change" would just change the details of the annual plan.

  • I also don't think you need an alt="" tag on the image. Images that are purely decorative or are described in text nearby don't need alt tags.

  CSS

  • A little margin-block: 2rem on .container would push it away from the top and bottom.

  • I would suggest not using px so much. Try relative units instead %, rem, em, vh, vw. They will help with responsive pages.

  • Also try avoiding setting fixed heights on elements. Use padding and margin instead to reach the desired height. This also helps with responsiveness.

  Well done, look really good.

  Marked as helpful

  1

  ---

  

  Igor•30

  @IgorDGomesPosted about 1 year ago

  @OneManBanned appreciate the feedback, i'll take it in mind for next projects!

  Thank you for the help!

  0