Design comparison
SolutionDesign
Solution retrospective
How better can I write the CSS? How differently would I have approached it?
Community feedback
- @techantherePosted almost 3 years ago
Few tips:
- Please use at least one semantic tag like the main element under the body tag is sufficient here which will contain all the other code.
- Use h1 here rather than h2
- Try to replace the units in px to rem instead because that makes content small or big relative to the root size. like the font-size can be changed to rem. You can also use an online px to rem unit calculator for this purpose, but it is rarely required unless you can't guess the right value for rem in your code.
- You don't need to use 100vw in the parent class as the width is set to 100% by default and if you ever need to change the width to something else, use rem units rather than vw or percentages.
- Use an anchor tag <a> wherever you see hover effect and replace the button code with a and keep the same styling as for button. Similarly change the p tag around the 'Cancel' to anchor tag. Hope it's helpful. Good lucks.
1@muturi254Posted almost 3 years ago@techanthere Thank you for the feedback will make sure to implement it in the next challenge.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord