Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary

@AnoshaSohail

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


feedbacks and best practices are welcomed

Community feedback

Ahmed El_Bald 1,020

@Ahmed-Elbald

Posted

Hi, I think you did a great job with the design, but you have some issues with naming things....

  • For instance, we don't usually use the underscore (_) to separate words when naming classes like in main_container. Instead, you should use the hyphen as main-container.
  • you can also change the name of some classes to a more meaningful ones, so classes like main-container, content and plans can be replaced with card, card-content, card-plans. That way it will look more connected to each other.
  • It might be a good idea to give your h1 a class of card-header and your p a class of card-description.

I hope you find that helpful.

Marked as helpful

1

@babarich1995

Posted

its good and very same according to the design

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord