Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary (CSS with mobile-first solution using Flexbox)

@JulianLivrone

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello Frontend Mentor Community,

With this project I tried to improve my structure and organization with CSS, even including a Table of Contents so you can see what is all about. Feel free to check my project and tell me what you think about it and how my CSS code is organise.

Any feedback is welcome! Thank you.

Community feedback

Elaine 11,400

@elaineleung

Posted

Hi Julian, well done here, especially in structuring the CSS! Things look very clean to me, and the component also looks good; I believe you just need some more padding in the content container (maybe try 1.5 or 2rem), and also add a bit of box shadow for the card, and that should get your card looking closer to the original.

About the CSS, I only got two thoughts here:

  1. I see that you used a pseudo selector for the text in the your plan; I actually would have that in the main HTML because this is really important content info! If you look in the DOM inspector, you may only see the ::after element but not the actual text, and you'd want that to be visible for sure, especially for screen readers. What I would do is, I would have the text together in a container, and then just make sure they are both block elements so that they won't be inline. The HTML could look something like this:

    HTML:
    
    <div class="plan">
       <h2>Annual Plan</h2>
       <span class="price">$59.99/year</span>
    </div>
    
  2. Right now I can only see the box-sizing rule as the only normalize rule. You can try adding a few more rules, especially the margin and padding zero rules. Here are two I recommend on every project:

    * {
       margin: 0;
       padding: 0;
       font: inherit;
    }
    img, picture, video, canvas, svg {
       display: block;
       max-width: 100%;
    }
    

By the way, in the HTML, you got some issues in the report that you'll need to check out; most likely you'll need to add a main tag (most likely just below the body tag will do), and that should take care of most of the issues.

Great job on the whole, and keep going 😊

Marked as helpful

0

@JulianLivrone

Posted

@elaineleung

Hello Elaineleung, thank you for taking the time to review my solution to this challenge.

I learned a lot thanks to your feedback, I have just uploaded the solution with the changes and fixes. Keep the good work, you teached me a lot!

Greetings.

1
Elaine 11,400

@elaineleung

Posted

@JulianLivrone No worries, glad to hear, Julian! 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord