Design comparison
Solution retrospective
šHello Front-End Mentor Community! This is my solution for this challenge!
What challenges did you encounter, and how did you overcome them?šļø The project was not demanding and there were no major problems
What specific areas of your project would you like help with?āļø Feedback welcome!
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @rembiszkacper
Your solution looks great!
I have a suggestion for improvement:
š Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.
Also, consider removing the
background-position
from the body and addingbackground-size: contain;
to it. This will place the image correctly.Hope that's helpful!
Keep up the great work!
Marked as helpful3@samirBenabdallahPosted 9 months agoI appreciate your advice and will take it into account in my future projects. @danielmrz-dev
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord