Order Summary Component

Community feedback

• 

  P

  subu•390

  @subu-vPosted over 2 years ago

  You did well to get the exact results, one thing i will suggest is that, you can clearly see that your background-image is the not same as the required design background-image.

  Yours get repeating.

  To stop this, use

  background-repeat : no-repeat;
  //this will stop repeating the background-image.
  

  Marked as helpful

  1

  ---

  

  Welyn Cespedes•50

  @Smailer022Posted over 2 years ago

  @subu-v Thank you!!

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Welyn Cespedes! 👋

  Great work on this challenge! Your solution looks pretty good! 😀

  I see some areas in your code that you can improve.

  • I recommend stopping the repetition of the background image by setting background-repeat: no-repeat.
  • Alternative text for images should not contain any words that are related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image.
  • Not all images need alternative text. In this case, all the images don't need alternative text because they are only for decoration purposes. So, I recommend leaving the alt="" empty. This way, all the images would not get pronounced by the screenreaders.
  • Always specify the type of the button. In this case, set the type of them as type="button". It's going to prevent the button from behaving unexpectedly.

  That's it! Hope you find this useful! 😁

  Marked as helpful

  0

  ---

  

  Welyn Cespedes•50

  @Smailer022Posted over 2 years ago

  @vanzasetia Thank you very much for the advice

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Smailer022 No problem! 👍

  0