Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Add background-repeat: no-repeat; and background-size: contain to the html.
To center .main_element on the page using flexbox, add align-items: center: justify-content: to the body. instead of giving it position absolute and its properties.
You forgot to add a box-shadow to .button and to give cancel-order the hover effect.
Hope am helpful HAPPY CODING
Marked as helpful1 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Increase 📈 the
width
of the component to better match the FEM example.
- The “illustration” and Music Icon serves no other purpose than to be decorative; they add no value. Their
alt tag
should left blank and have anaria-hidden=“true”
to hide it from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0 - Increase 📈 the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord