Order summary component with HTML/vanillaCSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Favrek, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • remove all margin from wrapper class because with flex they are superfluous
  • use flexbox to the body for center the card. Read here -> best flex guide
  • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container
  • try to add a little transition on the element with hover effect
  • For fix the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hello Favrek ! Congo 👏 on completing this challenge ,

  Let's look at some of your issues, shall we:

  -> Accessibility Issues occur due to lack semantic elements in the HTML Learn Semantic Elements

  -> background-size: cover; Here i would prefer "contain" over "cover"

  -> Overall you code is clean

  happy Coding😀

  Marked as helpful

  1