Design comparison
SolutionDesign
Solution retrospective
I didn't use the background-patten.svg as I don't like this. Instead I added the other background color! I hope it will be okay.
Community feedback
- @pantbibek21Posted about 3 years ago
As for the accessibility issues,
- You can remove this div class="main-section" as main class="card" or main class="main-section" . Our body should have one main element. This is not mandatory but it is recommended if we don't want to bring any accessibility issues.
- Since we are only building the card and you have used h2 for heading. That is fine if we had another h1 as heading above. So that is causing problem. Better to use h1. If you feel h1 is too big. You can still adjust size through css.
- You text of paragraph is not aligned perfectly. See it is kinda of awkward just to have a single word take whole line space. You can manage that by using br where you want to break and also maintain it by giving margin or padding to make it nicely arranged. I also new to web development. Hope this helps. PS. Did you used SCSS in your css? How did you used that :root { --primary-clr: rgb(31, 31, 100); --secondary-clr: rgb(131, 151, 179); --dark-blue: rgb(61, 26, 185); } What is called this method of writing css? Other is absolutely fine. You are doing great.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord