Order Summary Component with Grid and Flexbox CSS
Design comparison
Solution retrospective
Hello guys, I tried to do my best, but I dont know if I use all the properties correctly. I would like to know some specific points and I hope you can help me.
Did I correctly implement the BEM methodology? Did I correctly use grid and flexbox? Is there any way to improve or optimize my code? Thank you for your time and best wishes to you.
Community feedback
- @DavidMorgadePosted over 2 years ago
Hello freddy, congrats on finishing the challenge, it looks pretty great in my opinion, good job!
Your BEM looks well structured, I would make some changes like
sub-card
can go perfectly ascard__sub
andcard__change
for yourchange-plan
link.Also would change the links for
buttons
, this are probably not getting you to other site in a real projects (thats the point ofa
tags), they are just cancelling the order or changing the plan, wich means can perfectly fit as buttons, I'm referring tocard__cancel-order
andchange-plan
.This are minor changes, but as I said your projects looks perfect and you can leave it as it is.
Hope my feedback helps you in future challenges!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord