Design comparison
SolutionDesign
Solution retrospective
Is it okay that the user has to scroll to see the entire card or would it be better to set a height on the card?
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi lamy, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
- to improve the design of the page, we can do this:
body { background-size: 100% 50vmin; }
The rest is great!
I hope it helps... 👍
1@Lamy237Posted about 2 years agoHi @AdrianoEscarabote!
Thank you for your feedback. I added the main tag and updated the background-size and few other things. I actually didn't know about the unit vmin, so I learned something new today 😊.
Thanks again... 🙏
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord