Account Deleted
Hello @mbdelarosa 👏
Your solution is just perfect and I really appreciate your hard work
- But I don't know why you written
min-heighttwo times inbody elementand I think there is no need to write them two times
min-height: 100vh;
min-height: 100dvh;
- And I think
illustration-hero.svgis there for decoration and the image don't have any significant meaning that's why I think you can removealt attribute value
And you also can take a look of my solution
Hope that was helpful for you ☺️
0
Michelle Dela Rosa• 180
@mbdelarosa
Posted
@MrSandipSharma Thank you for your comment!
To be honest I only decided to include an empty alt on the img because it was failing the Accessibility and HTML Validation reports here on the solution page -- would it be fine if I just ignore the warning here?
I included two min-height properties since from what I've read so far, dvh is a new unit that might not be fully supported yet by some browsers which is why I added vh as a fallback. Hope this helps clear up things, thank you!
0
