Design comparison
Solution retrospective
Any feedback is welcome
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi Abieb_Guardian, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To make your page more like the example layout, we can do this:
body { background: url(./images/pattern-background-desktop.svg) #E1E9FF; background-repeat: no-repeat; background-size: 100% 50vmin; }
To improve the code structure wrap this div:
<div class="attribution">
with the semantic tag
footer
The rest is great!
I hope it helps... 👍
Marked as helpful0@AbibGuardian50Posted almost 2 years ago@AdrianoEscarabote Hallo Adriano,anyway thank you for the feedback that you give to me For the footer ,i really forget about that Thanks you,it really means a lot to me
Have a great day
1 - @denieldenPosted almost 2 years ago
Hello Abieb_Guardian, You have done a good work! 😁
Some little tips to improve your code:
- To fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
- use
main
tag to wrap the card and improve the Accessibility but not as a container of that one element - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - add
transition
andhover
effect on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful0@AbibGuardian50Posted almost 2 years ago@denielden Hi deniel! Thanks for your feedback,i will improve my future project with this feedback
Have a great day!
1@denieldenPosted almost 2 years ago@AbibGuardian50 You are welcome and keep it up :)
Have a great day you too!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord