Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Component with flex

Salman Maqboolโ€ข 80

@MXalman

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please let me know if there are any issues or ways to improve my code. Thank you!

Community feedback

Vanza Setiaโ€ข 27,795

@vanzasetia

Posted

Hi, Salman! ๐Ÿ‘‹

Congratulations on finishing this challenge! ๐ŸŽ‰

One suggestion I have is to leave the alternative text empty (alt="") for the music icon and the illustration. Those are decorative images. It means that they don't add any meaningful information to the page. This will tell the screen reader to simply skip over the image.

I recommend visiting the Solid Start website. Right there, it will give you an overview of web accessibility. Knowing about web accessibility will impact the way you write your code significantly.

I hope this helps! Happy coding!

Marked as helpful

1

Salman Maqboolโ€ข 80

@MXalman

Posted

@vanzasetia Thank You!

0
Vanza Setiaโ€ข 27,795

@vanzasetia

Posted

@MXalman You are welcome!

0
Mohan Krishnaโ€ข 160

@Mohan823

Posted

But it's not shrinking itself when review responsive design. Review my project here: https://www.frontendmentor.io/solutions/order-summary-using-grid-and-flex-tc2TOYFWCb

I also added padding both sides that u skipped when reviewing in mobile layout.

Marked as helpful

0

Salman Maqboolโ€ข 80

@MXalman

Posted

@Mohan823 Thank you!

0

@MelvinAguilar

Posted

Hi @MXalman ๐Ÿ‘‹, good job for completing this challenge!

Here are some suggestions to improve your code:

  • Use max-width: 350px to main selector instead of width.
  • Use min-height: 500px to main selector instead of height.
  • You can use <picture> tag when you need to change the image on different viewports, in this case it would be enough to use the div element, or use the image directly since the style of the <picture> is not modified, also remember to update the image with width: 100%;.
  • You should use the <a> tag to cancel the order
<a href="#" >Cancel Order</a>

I hope those tips will help you.

Good Job and happy coding !

Marked as helpful

0

Salman Maqboolโ€ข 80

@MXalman

Posted

@MelvinAguilar Thank you!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord