Submitted almost 2 years ago
Order Summary Card Solution using CSS Flexbox
@rameesha0126
Design comparison
SolutionDesign
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hi there π. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.
- Not all images should have alt text. Music icon and the hero image are for decoration purposes only, so they can be hidden from screen-readers by adding
aria-hidden="true"
and leaving its alt attribute empty:
<img src="illustration-hero.svg" class="hero-image" alt="" aria-hidden="true"> <img src="icon-music.svg"alt="" aria-hidden="true">
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding and Happy New Year! πππ
Marked as helpful3 - Not all images should have alt text. Music icon and the hero image are for decoration purposes only, so they can be hidden from screen-readers by adding
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord