Submitted over 1 year ago
Order Summary Component w/ CSS Grid and custom CSS properties
@newtothis90
Design comparison
SolutionDesign
Solution retrospective
If anybody has any comments or any changes you would make. Please let me know!
Thanks!
Community feedback
- @fernandolapazPosted over 1 year ago
Hi π, just a couple of things in case you want to take a look:
HTML / ACCESSIBILITY:
- The icon is a decorative image and therefore needs an empty
alt
attribute to be ignored by a screen reader.
CSS:
- You might consider using relative units like rem or em since they are better for scalable layouts. Something simple to start with would be to convert to rem (1 rem equals the font size of the root element, 16px by default). Consider this suggestion especially for the
font-size
.
I hope itβs useful : )
Nice solution btw.
Regards,
Marked as helpful0@newtothis90Posted over 1 year ago@fernandolapaz
That was very helpful! Especially the icon being a decorative image and having an empty alt attribute.
Thank you very much for taking the time to give me your advice! It's very appreciated.
1 - The icon is a decorative image and therefore needs an empty
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord