Order Summary Component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Mhizdhee! 👋

  Good effort on this challenge! 👍

  I have a few suggestions for this solution.

  • As you may already know that the card is bigger than the original design. So, I would recommend trying to adjust the styling of the card. You don't need to make it to be "pixel-perfect". As long as it looks similar then it's would be good. 🙂
  • I notice that there's no background color and background image on screen sizes that are bigger than 1440px. I would recommend keeping both on any screen sizes.

  I highly recommend writing the styling using the mobile-first approach. So, instead of using max-width media queries, you will use min-width media queries instead. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles.

  I hope this helps! 👍

  Marked as helpful

  0
• 

  mubizzy•1,520

  @mubizzyPosted over 2 years ago

  Excellent job on this challenge! your report has a few issues though:

  1. wrap everything in your body in <main> or use semantics

  2.   it is a best practice to use both HTML 5 and ARIA landmarks to ensure all     content is contained within a navigational region.

  Hope it helps:)...don't forget to mark it as helpful 👍

  You can get more details here...click here

  0
• 

  Mhizdhee•50

  @MhizdheePosted over 2 years ago

  Hello Vanza,

  Thanks so much for this feedback. It was really helpful. I learnt a lot while working on the responsiveness. Thank you.

  0