Design comparison
Solution retrospective
Any feedback on how i can improve will be really appreciated.
Community feedback
- @MohamedHussein05Posted over 3 years ago
Great work on this one, I'll just Suggest few things to improve your work:
-
The Card doesn't appear properly in the Landscape mode using
body { (min-height: 100vh;) }
instead of the current rule and removing#bottom-section { (height: 70%;) }
will fix it. -
It's not recommended to set height on the card Use paddings & margins instead.
-
The scrollbar isn't very nice, disabling it will give your page a better look.
-
Try as hard as you can not to use height .. but If you must use min-height.
Marked as helpful0@jimavictorPosted over 3 years ago@MohamedHussein05 Thanks a lot for the feedback. i will make these changes as soon as i can..
0 -
- @hardy333Posted about 3 years ago
Nice work.
4
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord