Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary component using vanilla css

jimavictor 375

@jimavictor

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback on how i can improve will be really appreciated.

Community feedback

@MohamedHussein05

Posted

Great work on this one, I'll just Suggest few things to improve your work:

  1. The Card doesn't appear properly in the Landscape mode using body { (min-height: 100vh;) } instead of the current rule and removing #bottom-section { (height: 70%;) } will fix it.

  2. It's not recommended to set height on the card Use paddings & margins instead.

  3. The scrollbar isn't very nice, disabling it will give your page a better look.

  4. Try as hard as you can not to use height .. but If you must use min-height.

Marked as helpful

0

jimavictor 375

@jimavictor

Posted

@MohamedHussein05 Thanks a lot for the feedback. i will make these changes as soon as i can..

0
P
hardy 3,660

@hardy333

Posted

Nice work.

4

jimavictor 375

@jimavictor

Posted

@hardy333 thank you

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord