Vanza Setia• 27,795
@vanzasetia
Posted
Hello there! 👋
Congratulations on finishing this challenge! 👏
Some suggestions.
- There's no need to change the
max-widthof the card element. - I recommend adding some
paddingon thebodyelement to prevent the card from touching the edges of the browser. Currently, on my desktop view (1280px * 680px), the card is touching the top and the bottom edges. - Always specify the
typeof thebutton. In this case, set the type of them astype="button". It's going to prevent the button from behaving unexpectedly.
That's it! Hope you find this useful! Happy coding! 😄
Marked as helpful
2
@vanzasetia Thank you for the suggestions, I've implemented them so you can take a look again if you wish.
0
Vanza Setia• 27,795
@vanzasetia
Posted
@andrijaivkovic I took a look at your updated solution and everything's looking good. Great job on the updates! 👍
0
