Design comparison
SolutionDesign
Community feedback
- @tea-scriptsPosted over 2 years ago
Great effort completing the challenge. Some few points:
- You can also have your
<a>
inside of your<li>
. You can't place it directly as a child of theul
orol
. - Try placing your entire markup (from the start of your
body
till the end of same) in a landmark like<main>
. - Although it's not important when working alone but keeping a clean and organized code is considered best practice if other developers would be taking a look or working with your code.
- You do not need to use a
<span>
to style the text content of abutton
you can apply all those style directly on the button using the selector or adding a class to the button. If you have different buttons on the same project you can add an additional class or Id to overwrite some generic styles. - In the challenge the "cancel order" should not have a background and also you might want to add that background to your
ul
where you have your "plan". - Lastly you might want to look into
box-shadow
CSS property. In simple terms this helps makes your design look like a card. Great job so far, happy coding 👍!
Marked as helpful1@DroobingNoobPosted over 2 years ago@coder-teamie thank you so much for your suggestions . Really appreciate it.
1 - You can also have your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord