Order Summary Component | Using HTML and Sass

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi there! 👋

  Well done on this challenge! It's great that you leave the alt empty for all decorative images which in this case, all images are decorative. So, good job! 👍

  I would recommend using a grid if you need to create a layout that needs the x and y directions. If it's only one direction, like the horizontal or vertical access then flexbox would be the choice.

  Also, about nesting in Sass, I would recommend only nesting when you are going to use:

  • A media query
  • Pseudo class and pseudo element

  Reference: Sass Guidelines - https://sass-guidelin.es/

  Some suggestions from me,

  • Don't limit the height of the body element, it will not allow the users to scroll the page if the page content needs more height. Use min-height instead.
  • Fix the attribution positioning, on mobile landscape view (360px * 640px), the attribution is on the top of the card element.

  I hope you find this information beneficial. Happy coding! 😄

  Marked as helpful

  1

  ---

  

  BETOUIL Anass•40

  @XelleriumPosted over 2 years ago

  @vanzasetia

  Hello Vanza! Thank you for your kind remarks, I really appreciate it. Yeah I think I should definitely start working with flexbox more and try to figure out how to correctly use both layouts in different situations.

  I'll try and read more about Sass guidelines as well because I've never actually read that much into it. I pretty much just saw a quick tutorial on how to use it rather than figuring out the proper way to utilize it.

  Thank you so much for these remarks, I'll definitely keep them in mind when doing other challenges in the future! 😊

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Xellerium You're welcome! 😄

  0