Design comparison
Solution retrospective
Feedback on this will be great and any feedback on how i can improve this solution will really be helpful. any feedback is appreciated thank you all guys
Community feedback
- @denieldenPosted almost 3 years ago
Hi kasemkl, I took some time to look at your solution and you did a great job!
Also for fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
Overall you did well :)
Hope this help and happy coding!
Marked as helpful0 - @GitHub-dev12345Posted almost 3 years ago
If you want to reduce accessibility to change this code 😊
<div class="attribution"> to <footer> ( Used footer tag );Marked as helpful0 - @GitHub-dev12345Posted almost 3 years ago
Congratulation to complete the challenge ❤️👍 My small suggestion : 1.In Card design Used This CSS Code:
transform : scale(0.8); this property decrease the size of card. 😉
large size for increase the number of scale & small size for decrease the number of scale
I hope you find this helpful
Marked as helpful0 - Account deleted
Hello there! 👋
Congratulations on finishing your challenge! 🎉
I have some feedback on this solution:
- Always Use Semantic HTML instead of
div
like<main>
<header>
<footer>
, etc for more info
i hope this is helpful and goodluck!
Marked as helpful0 - Always Use Semantic HTML instead of
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord