Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
BACKGROUND iMAGE πΈ:
- Looks like the
background svg
andcolor
has not been set properly, let me explain How you can easily apply thebackground color
with thesvg
they provided.
- Add the following style rule to your css, and then experience the changes
body { background: url(./images/pattern-background-desktop.svg), #E1E9Ff; background-repeat: no-repeat, no-repeat; }
- Tip, Don't forget to generate a new screenshot after editing the
css
file
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @HassiaiPosted over 1 year ago
There is no to give the body a width and height value, give the body a background-color of pale-blue and give the body a background-size of contain and background-repeat of no-repeat.
There is no need to style the main.
To center .card on the page using flexbox and grid instead of margin,
- USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
- USING GRID: Add min-height:100vh; display: grid place-items: center to the body
body{ min-height: 100vh; display: grid; place-items: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here.
For a responsive the width in .card with
max-width
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@SixcoolZPosted over 1 year ago@Hassiai Thanks, It was really helpful and I appreciate. Made the changes you suggested and it worked.
0 - @sumanth-chandanaPosted over 1 year ago
Hi mate!, congratsπ on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
- Use the
alt
(alternate text) attribute as mentioned in your Accessibility Report.alt
attribute is used for Screen readers applications. - Why does alt attribute matter? Read here.
- Use
background-repeat: no-repeat
to stop repeating the background for more on it click here - To avoid accessibility issues "All page content should be contained by landmarks" use code as :
<body> <main> ---your code here---- </main> <footer> </footer> </body>
(why does
<main>
matter? Read here )- For proper centering the container(whole card) vertically and horizontally you can also use the following simple block of code use code:
body { min-height: 100vh; display: grid; place-content: center; }
- When we open the GitHub repository link, you will find an About Section on the right side. There, also include a live preview link of your project. It is better for someone to check your live project while interacting with code.
I hope you will find this Feedback Helpful.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord