Design comparison
Community feedback
- @loganbriggs08Posted over 1 year ago
Hey Taylor, Your QR component looks great however I have a few suggestions to take your QR Component to the next level..
My first suggestion is that you lower your Card that is holding everything, this will make it look closer to the original image you copied off and make it look even better.
My second suggestion is that you make your Card a little bit bigger once its further down/centred, This will again make it look closer to the original and make the quality of your work even higher.
Anyways have a great day : )
Marked as helpful0 - @Finney06Posted over 1 year ago
Hello there π. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
-
Images should have alternate text.
<<img src="images/icon-music.svg">alt="music icon">
this provides alternative text descriptions of images for people who are visually impaired and rely on screen readers to navigate the web. Screen readers can read the alt text aloud, enabling these users to understand what the image represents and how it relates to the content on the page. Overall, including alt text in HTML is an important best practice for creating accessible and user-friendly web content. -
Wrap the page's whole main content in the
<main>
tag. -
Always avoid skipping heading levels; Starting with
<h1>
and working your way down the heading levels (<h2>
,<h3>
, etc.) helps ensure that your document has a clear and consistent hierarchy. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections.
Here is a web accessibility evaluation toolπ to check your webpage for any remaining errors or warnings related to landmarks.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord