Design comparison
Solution retrospective
I need to understand how to control the zooming in in browser. so that when a client zooms my website in, it will not spoil the code
Community feedback
- @denieldenPosted over 2 years ago
Hi Okunola, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - use
img
element instead a stylingdiv
for the top image of card - remove
margin
frominner-con
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
Marked as helpful1 - add
- @SamadeenPosted over 2 years ago
Hey Okunola!! Cheers 🥂 on completing this challenge.. . Here are my suggestions 1.You should use <main class="container"> instead of <div class="container">. 2. Go down orderly when you are using the headings h1 down to h2 down to h3 and so on. This should fix your accessibilities issues . As for the HTML issue try removing the type attribute on the image tag
. Regardless you did amazing..I hope you find the helpful.. Happy coding!!!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord