Design comparison
Solution retrospective
Hi, this is my first challenge here, any sugestions to improve my code will be highly appreciated.
Community feedback
- @RMK-creativePosted about 3 years ago
Hi Sudheer, congrats on completing your first frontend mentor project! 🎉 You've done a really good job with getting your solution to look like the design - nice work 👍
My main suggestion for improvement would be to work on using semantic html, as it will give better structure and readability to your code, and your site will be more accessible to screen readers and keyboard users. Currently, if I try to navigate around your page using only my keyboard, I can't interact with anything in order to change my subscription or go to the payment page.
Keep going, once you've got a handle on semantic markup, your projects will be lit 🔥
Marked as helpful1@sudheerkmrPosted about 3 years agoHi Rachel, Thank you 🙏 for taking the time and providing your valuable suggestion. I will try to work on using semantic html and improve accessibility in all my upcoming projects.
0 - @seekinfoxPosted about 3 years ago
cannot find your code. i think you did not provide your project repository properly.
Marked as helpful0@sudheerkmrPosted about 3 years ago@seekinfox thanks for pointing out, I have updated the solution link please check it out.
0@seekinfoxPosted about 3 years ago@sudheerkmr for starters, update your README.md file so visitors can have overview of your project without needing to go through your code.
In download kit you have readme-template.md file, reference it for README.md file.
and for code improvement, build more projects. :)
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord