Design comparison
Solution retrospective
I couldn't figure out how to position the background image, so i just made use of a solid color. If anybody knows how to go about it, do let me know, thanks
Community feedback
- @tesla-ambassadorPosted over 2 years ago
Hey Kushyzee. This is pretty impressive, congrats on completing your challenge! Here's a few tips:
- To answer your question on background positioning, you can use the
background-position
css property more on this if you follow this link You could also set the background size to match that of the design usingbackground-size
css property. - The responsiveness is a little off between 810px - 1149px. I think it'd be okay if you centered it and reduced the width of the card component a little to let's say (80% because I think you preffer it to be a little wider)
- To fix your accessibility issue, you might want to enclose your <div> with the class "attribution" in a footer landmark. Happy coding and keep on coding!
Marked as helpful0@kushyzeePosted over 2 years ago@tesla-ambassador Thanks so much for your feedback, I followed them accordingly and now i believe it's looking much better
1 - To answer your question on background positioning, you can use the
- @FluffyKasPosted over 2 years ago
Heyo,
You can add the background image together with the colour, they just need to be comma separated. Like so:
body { background: url(images/pattern-background-mobile.svg), var(--paleblue); background-repeat: no-repeat; background-size: contain; }
Marked as helpful0@kushyzeePosted over 2 years ago@FluffyKas Thanks very much for this, it helped a lot. It seemed not to work at first but when I switched the background-size to cover, it came out well
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord