@AdrianoEscarabote
Posted
Hi Hyeon Park, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem
To prevent the background image from breaking at higher resolutions, we can prevent this in two different ways:
-
Add a
background-repeat: repeat-x;, the image will repeat on the horizontal axis, preventing it from breaking. -
Add a
background-size: 100% 50vmin;, the50vminwill set its height as the page target, and100%will make it stretch on the horizontal axis.
Feel free to choose one of the two!
The rest is great!
I hope it helps... 👍
Marked as helpful
@hkparkjs
Posted
@AdrianoEscarabote
Nice to meet you! Your advice and the tool you recommend really helped me and I changed font size units from px to rem.
I have some question.
- I'm wondering if there is a breaking case at higher resolutions when applying
background-size: containin body element. - When applying
background-size: 100% 50vmin;, what does the 50vmin mean? I mean, I would like to know why I should set the background's height to half of the screen height in this case.
Thank you very much :)
