Design comparison
Solution retrospective
I'm starting to finish these newbie projects slightly faster each time! But I still have a long way to go.
Here I'm mostly concerned about how I'm using and referring to classes. Any feedback is greatly appreciated!
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @mhykah-webdev!
Your project looks great!
I have a suggestion for improvement:
- You don't need to insert the background image using a
picture
or even aimg
tag. You can add it as a background along with thebackground-color
. It's possible to usebackground-color
and abackground-image
together. So you can remove the tagpicture
and add the image as the body background.
I hope it helps!
Other than that, you did an excelent job!
Marked as helpful1@mhykah-webdevPosted 11 months ago@danielmrz-dev Thank you so much for your help! I didn't know about background image so it was really helpful. I've updated the project and removed the picture tag. It also lets me change the background through media queries along with everything else which makes it much cleaner.
1 - You don't need to insert the background image using a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord