Design comparison
Solution retrospective
Not sure if my code is good and if I should use rem or em for the sizes. Any suggestions will be helpful, thanks!
Community feedback
- Account deleted
Hi, I prefer using rem units because the math is a lot simpler. If you set your root HTML font size to 62.5% which is 10px. The body font size would calculate to be 16/10 = 1.6rem. You did a great job and I suggest you can add a min-height 100vh rather than height 100vh because the element would occupy space of the web page. Here is an article explaining min-height: https://www.positioniseverything.net/css-min-height/ Hope this helps.
Marked as helpful0@OdallocPosted about 2 years agoHi @bccpadge! Thanks for your suggestions. I'll check the article, you're a great help 😁.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord