Design comparison
SolutionDesign
Solution retrospective
This is a resubmit incorporating helpful feedback to an earlier version.
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @atoopdev 👋🏻
I've got a couple of tips for the project.
- For the music icon, add
aria-hidden="true”
, because it's for decoration. You can read more aboutaria-hidden
here. Like this:
<img src="images/icon-music.svg" class="item-img" alt="" aria-hidden="true”>
- Also, I suggest adding
transition: all 0.2s;
to the button and the links, this will make:hover
smoother. - Lastly, I see you've got a second submission for the same project. There's nothing wrong with submitting again, however, what you'd usually do is to make some changes on the existing project and push it to GitHub. After that the changes you've made will also appear on here, but the screenshot will stay the same. You can generate a new screenshot if the changes are drastic, but the most important thing is the real project.
I hope this was helpful 👨🏻💻 other than that, you've made some great progress, keep it up. Cheers 👾
0@atoopdevPosted about 3 years ago@kens-visuals Oh thank you - I wasn't sure if I was supposed to update the code or submit again. Thank you for clarifying. Thank you for the additional suggestions as well, much appreciated.
0 - For the music icon, add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord