Design comparison
SolutionDesign
Community feedback
- @denieldenPosted about 2 years ago
Hi Grixxxx, congratulations on completing the challenge, great job! 😁
Some little tips for optimizing your code:
- To fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
- use
main
tag to wrap the card and improve the Accessibility but not as a container of that one element - also you can use
article
tag instead ofmain
tag to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
picture
container of image - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding 😉
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord