Design comparison
Solution retrospective
Dear Devs, please share me your feedbacks. It will go a long way, thanks.
Community feedback
- @pradeeps4iniPosted over 2 years ago
Hi, Osho.
Congrats on completing the project. I would like to suggest some changed to your code.
-
In the HTML use semantic markup. You're using div for the container. Since this card is the only content on the page, you should use <main> as the wrapping element.
-
In the CSS you're working with fixed width for all your elements. Learn about max-width. It will help you make your card more responsive.
-
On the parent container, you can use "overflow: hidden". Then you won't have to specify the border radius on image top, image part that flows out of the container, will truncate on its own.
-
Learn about custom properties. And make color names and font weights custom properties. In case you want to change them in future, you'll only have to change the value of custom properties and not change the value everywhere in CSS.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord