@dimar-hanung
Posted
Hi.. 👋, Congratulations on completing the challenge 🎉 .
I have some interest and feedback with your code
That i like:
- I really appreciate the well-structured folder organization. 👌
- CSS Naming is also good, represent what is it for, like
<div class="plan">
for plan section
My Feedback:
- I noticed that you're missing a closing
</div>
tag for the div with the class "container". Please add the closing</div>
tag right above the</body>
tag to fix the issue. - I suggest you use html semantic convention, for example
<div class="container">
to<main class="container">
, it will make it clearer, and will improve seo if you want to submit your website to google, i recomended this article: here - maybe you can use tools like prettier to format your code to be more beautiful ( TIP: set prettier configuration to format on save, make it easier )
About your question:
-
To fix the background image issue, try using the
./
path notation for the image URL in your CSS. This will look for the image in the current directory. Change yourbody
background property to:body{ background: url(./images/pattern-background-mobile.svg), hsl(225, 100%, 94%); }
-
you can use grid for simple centering div content ( Don't forget the issue earlier, put the closing tag above the closing body tag first )
.container{ min-height: 100vh; display: grid; place-items: center; }
anyways overall is good, nice solution, hope it useful 🙌
Marked as helpful
@ZaiinabM
Posted
Okay, didn't notice there was no closing tag, will fix that and also effect other corrections. Thank you for the feedback! @dimar-hanung