Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary component using Flex

ZaiinabM 30

@ZaiinabM

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello guys, I just completed the order summary project. I struggled with positioning and sizing my divs. Also couldn't get the background image to work/display. Kindly check it out and review where corrections are necessary. Thank you.

Community feedback

@dimar-hanung

Posted

Hi.. 👋, Congratulations on completing the challenge 🎉 .

I have some interest and feedback with your code

That i like:

  1. I really appreciate the well-structured folder organization. 👌
  2. CSS Naming is also good, represent what is it for, like <div class="plan"> for plan section

My Feedback:

  • I noticed that you're missing a closing </div> tag for the div with the class "container". Please add the closing </div> tag right above the </body> tag to fix the issue.
  • I suggest you use html semantic convention, for example <div class="container"> to <main class="container">, it will make it clearer, and will improve seo if you want to submit your website to google, i recomended this article: here
  • maybe you can use tools like prettier to format your code to be more beautiful ( TIP: set prettier configuration to format on save, make it easier )

About your question:

  • To fix the background image issue, try using the ./ path notation for the image URL in your CSS. This will look for the image in the current directory. Change your body background property to:

    body{
        background: url(./images/pattern-background-mobile.svg), hsl(225, 100%, 94%);
    }
    
  • you can use grid for simple centering div content ( Don't forget the issue earlier, put the closing tag above the closing body tag first )

    .container{
     min-height: 100vh;
     display: grid;
     place-items: center;
    }
    

anyways overall is good, nice solution, hope it useful 🙌

Marked as helpful

0

ZaiinabM 30

@ZaiinabM

Posted

Okay, didn't notice there was no closing tag, will fix that and also effect other corrections. Thank you for the feedback! @dimar-hanung

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord