Order Summary Component using CSS custom properties
Design comparison
Solution retrospective
Are there any areas that could be used a more definite solution instead of random, guessed numbers? For example using vh on border-radius instead of guessing which number of px.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello, CodeyBrodey! 👋
Good effort on this challenge! 👍
Regarding your question, when I wasn't a PRO member, I would try guessing the value for the
border-radius
. Not only theborder-radius
but also the amount ofpadding
andmargin
(and much more). So, I guess the only way is to keep trying until it looks similar to the design. 😅Also, don't worry too much about it. It's okay if the site is not looking the exact same as the original design. As long as it looks similar then it's good enough. I would recommend focusing more on the code quality instead. 😉
Some feedback from me.
- I would not recommend using viewport units for
border-radius
. It is because the viewport units are relative to the user's screen size. So, some users might see the card have more rounded corners and some might not be able to see theborder-radius
. - Use single class selectors for styling whenever possible instead of
id
.id
has high specificity which can lead to a lot of issues, especially on the larger project. It's best to keep the CSS specificity as low and flat as possible. 😉
I hope this helps! 😁
Marked as helpful0@vanzasetiaPosted over 2 years ago@CodeyBrodey You're welcome! I am glad that you found it helpful! 😄
0 - I would not recommend using viewport units for
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord