Order summary component using BEM, Flexbox, sass

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Excellent work on this solution, Isaias! Your solution is responsive and looks great! 👍

  Some feedback from me.

  • I recommend leaving all the alt empty for all the images on this site. They are decorative images which means that they don't add or contain any information so, it's best to hide them from the users of a screen reader. This way, those users won't have to listen to unrelated content.
  • I highly suggest specifying the type for every button element. It's going to prevent the button from behaving unexpectedly.

  I hope this helps! Keep up the good work! 👍

  Marked as helpful

  0

  ---

  

  P

  isaias•260

  @IsaiasVillegasPosted over 2 years ago

  @vanzasetia oh that's right , I totally forgot to specify the type for the button element 😂😂. Thank you very much for your suggestions. 😄👍

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @IsaiasVillegas No problem! 😄

  0
• 

  Danilo Blas•6,300

  @Sdann26Posted over 2 years ago

  Esta bastante apegado al diseño y tiene buenas transiciones además que el responsive tambien funciona.

  Te recomiendo que corrijas los problemas del reporte. En si estos aparecen porque siempre dentro del body debes tener una etiqueta main que englobe el contenido principal de tu página en este caso la card que has hecho. Puedes meter dentro tambien el div con la clase class="attribution" o cambiar el div por un footer y colocarlo debajo del main.

  Por ultimo no olvides que siempre debe haber un h1 para que no halla ningun error.

  Genera un nuevo reporte apenas hallas corregido esos cambios.

  Suerte con tus futuros proyectos Isaias!

  Marked as helpful

  0

  ---

  

  P

  isaias•260

  @IsaiasVillegasPosted over 2 years ago

  @Sdann26 Muchas gracias por comentar y por tus sugerencias, la verdad no entendía muy bien los problemas que decía el reporte 😂, gracias por explicar ahora ya tengo una idea de cómo corregirlos.😃

  1
• 

  zoleee98•250

  @zoleee98Posted over 2 years ago

  you can fix your background using background-size: contain;

  also your card seems a bit larger, just simply use transform: scale(); on your card

  0

  ---

  

  P

  isaias•260

  @IsaiasVillegasPosted over 2 years ago

  @zoleee98 Thank you very much for your suggestions, I will take them into account. 😄👍

  1