Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Your session has expired please log in again.
Your session has expired please log in again.
Your session has expired please log in again.
Your session has expired please log in again.
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order summary component

@MateTheBrogrammer

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Abdul Khaliq ๐Ÿš€โ€ข 72,580

@0xabdulkhaliq

Posted

Hello there ๐Ÿ‘‹. Congratulations on successfully completing the challenge! ๐ŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

BACKGROUND iMAGE ๐Ÿ“ธ:

  • Looks like the background image has not been properly set yet, they are misplaced due to the usage of individual img element. Actually there's an easy way to handle this problem with positioning the background images without using img elements
  • Add the following style rule to your css, and then experience the changes
body {
background: url(./images/pattern-background-desktop.svg) no-repeat, #E1E9Ff;
background-size: contain;
}
  • Now you can remove these individual img element from the html and their corresponding style rules too
<div class="Background-Img"></div>

.Background-Img {
background: url('./images/pattern-background-desktop.svg') no-repeat center/cover;
height: 600px;
position: fixed;
left: 0;
right: 0;
top: 0;
bottom: 0;
z-index: -1;
}
  • Tip, Don't forget to generate a new screenshot after editing the css file

.

I hope you find this helpful ๐Ÿ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0
Sachinโ€ข 830

@Sachin-Mahato

Posted

Well done for completing the challenge

As a front-end developer, your job is to make the website look just like the designer wants it to. If there are any differences, try to fix them quickly so that the website matches the design as soon as possible.

This challenge consists of two parts: the mobile component and the desktop component. However, it appears that the mobile part has not been developed. It's important to address this issue and ensure that both the mobile and desktop aspects of the challenge are completed.

1. Lack of semantic HTML:

  • Semantic HTML elements are missing or not used appropriately.
  • The structure does not convey the meaning and purpose of different parts of the webpage.

-.Every site should ALWAYS have โœ… a main element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serve as the componentโ€™s container โš ๏ธ.

--

More info

.Avoid skipping heading levels โš ๏ธ.

  • Always start with the h1 (which can only be used once) and you will go down the hierarchy level depending on the headingโ€™s level of importance.

More info

2. Usage of absolute units instead of relative units:

  • Absolute units like pixels (px) are used for defining lengths and sizes instead of relative units like percentages (%), em, or rem.
  • Relative units are more flexible and responsive across different screen sizes.

More info

3. Reliance on CSS positioning properties instead of modern layout techniques:

  • CSS positioning properties are used extensively, causing difficulties in managing and maintaining the layout.
  • Consider adopting modern layout techniques like Flexbox or Grid for improved flexibility and easier maintenance.

Helpful links

-Flexbox

-Grid

I hope you find this helpful and happy coding

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord