Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
To make the background-image visible add "./" to the beginning of the url value
url("./images/pattern-background-desktop.svg");
instead of url("images/pattern-background-desktop.svg");There is no need to give the body a background-position, rather give it a background-size of contain.
To center the main on the page using grid, replace the height in the body with
min-height: 100vh
.body{ min-height: 100vh; display: grid; place-items: center; }
For a responsive content, replace the width in the main with max-width and increase its value for it to be equivalent to the design.
max-width: 416px which is 26rem/em
.Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1 - @0xabdulkhaliqPosted over 1 year ago
Hello there ๐. Congratulations on successfully completing the challenge! ๐
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS ๐:
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful ๐ Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord